Return "invalid parameter" when linking to non-existing container #39852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2019
thaJeztah
force-pushed
the
detect_invalid_linked_container
branch
from
12ddad2
to
cf470e9
Compare
thaJeztah
force-pushed
the
detect_invalid_linked_container
branch
from
cf470e9
to
2c3e001
Compare
|
Only failure is a flaky test (tracked through #38521) |
Trying to link to a non-existing container is not valid, and should return an "invalid parameter" (400) error. Returning a "not found" error in this situation would make the client report the container's image could not be found. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
detect_invalid_linked_container
branch
from
2c3e001
to
422067b
Compare
|
ping @tiborvass @cpuguy83 PTAL |
tiborvass
approved these changes
Sep 10, 2019
|
Failure on RS1 is https://ci.docker.com/public/job/moby/job/PR-39852/5/execution/node/180/log/ which is known to be flaky (#36801), and for which I have a PR to skip it conditionally; #39856 Everything else is green, so I'll go ahead and merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39823
fixes docker/for-mac#3871
Trying to link to a non-existing container is not valid, and should return an
"invalid parameter" (400) error. Returning a "not found" error in this situation
would make the client report the container's image could not be found.