-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+) #39883
Conversation
ping @kolyshkin @tiborvass PTAL |
Looks like
Test was updated in #39616 to fix the flakiness, but the interesting bit there is that the retry loop should have a 3 second sleep before retrying, but looking at the failure above, the test started (and failed) within a second, which means that |
Opened #39885 to add more debugging to that test |
RS1 failing on #38521
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
365047d
to
7663aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(separating from #39549)