Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/parsers/kernel: gofmt hex value (preparation for Go 1.13+) #39883

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

thaJeztah
Copy link
Member

(separating from #39549)

@thaJeztah
Copy link
Member Author

ping @kolyshkin @tiborvass PTAL

@thaJeztah
Copy link
Member Author

Looks like DockerSwarmSuite.TestSwarmClusterRotateUnlockKey is still flaky; https://ci.docker.com/public/job/moby/job/PR-39883/1/execution/node/211/log/

20:24:13  FAIL: docker_cli_swarm_test.go:1333: DockerSwarmSuite.TestSwarmClusterRotateUnlockKey
...
20:24:13  docker_cli_swarm_test.go:1413:
20:24:13      c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
20:24:13  ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc000934240), Stderr:[]uint8(nil)} ("exit status 1")
20:24:13  ... Error response from daemon: rpc error: code = Unknown desc = The swarm does not have a leader. It's possible that too few managers are online. Make sure more than half of the managers are online.
20:24:13  

Test was updated in #39616 to fix the flakiness, but the interesting bit there is that the retry loop should have a 3 second sleep before retrying, but looking at the failure above, the test started (and failed) within a second, which means that
a different error / output was returned.

@thaJeztah
Copy link
Member Author

Opened #39885 to add more debugging to that test

@thaJeztah
Copy link
Member Author

RS1 failing on #38521

https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-39883/runs/1/nodes/178/log/?start=0

 ----------------------------------------------------------------------
 FAIL: docker_cli_start_test.go:190: DockerSuite.TestStartReturnCorrectExitCode
 
 docker_cli_start_test.go:200:
     c.Assert(exitCode, checker.Equals, 12, check.Commentf("out: %s", out))
 ... obtained int = 125
 ... expected int = 12
 ... out: time="2019-09-09T19:13:46Z" level=error msg="error waiting for container: EOF" 

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants