-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: remove GOMETALINTER_OPTS #39900
Conversation
This `ENV` was added to the Dockerfile in b96093f, when the repository used per-architecture Dockerfiles, and some architectures needed a different configuration. Now that we use a multi-arch Dockerfile, and CI uses a Jenkinsfile, we can remove this `ENV` from the Dockerfile, and set it in CI instead if needed. Also updated the wording and fixed linting issues in hack/validate/gometalinter Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ping @kolyshkin @vdemeester PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failures on RS1; this one is not (yet) marked as flaky, but was mentioned in #39747 (comment) to be timing out on RS1 Previously it was disabled on Windows (known to be failing); #34340
And a known flaky; tracked through issue #38521, and for which there's a WIP PR (that stalled unfortunately); #38595
Failure on RS5 was a Jenkins issue https://ci.docker.com/public/job/moby/job/PR-39900/1/execution/node/72/log/
|
Everything else is green; I'm merging this one, because the changes in this PR do not affect anything that's running on Windows, so those failures are definitely unrelated |
This
ENV
was added to the Dockerfile in b96093f (#34759),when the repository used per-architecture Dockerfiles, and some architectures needed
a different configuration.
Now that we use a multi-arch Dockerfile, and CI uses a Jenkinsfile, we can remove
this
ENV
from the Dockerfile, and set it in CI instead if needed.Also updated the wording and fixed linting issues in hack/validate/gometalinter
Note that this changes the
--deadline
to use the default (10m), which probably isn't a big issue (note that on the Go 1.13 update PR, we actually run into the 2m deadline #39549, which is when I found that we override the default 10m)