Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Windows unit tests - move to junit #40051

Closed
wants to merge 3 commits into from

Conversation

thaJeztah
Copy link
Member

opening on behalf of @vikramhh. This is opened from the same branch as #39971 from his repository

Part of work required for #39675 on Windows.
#39638 covers the corresponding work on Linux.

Signed-off-by: Vikram bir Singh vikrambir.singh@docker.com

- What I did
Added functionality to Unit test execution code to build and use gotestsum.exe for test execution

- How I did it
Modified the Unit test execution code in hack\make.ps1

- How to verify it
Execute unit tests and verify that test output is present in the bundles directory under root.

- Description for the changelog

Build and use gotestsum.exe for unit test execution\

- A picture of a cute animal (not mandatory but encouraged)

Vikram bir Singh added 2 commits September 24, 2019 00:24
Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
@thaJeztah thaJeztah requested a review from tianon as a code owner October 7, 2019 12:50
@thaJeztah thaJeztah changed the title Build and use gotestsum for running unit tests WIP: Windows unit tests - move to junit Oct 7, 2019
Signed-off-by: Vikram bir Singh <vikrambir.singh@docker.com>
@vikramhh
Copy link

vikramhh commented Oct 8, 2019

@thaJeztah - I had moved my branch further by pulling in changes from upstream. I see now it would pollute the history with needless commits that cannot be squashed into fewer commits.

I wish to keep the history as clean as possible. So if you feel it is OK, could you please drop all 3 existing commits that are currently attached to this PR. And pull af4e179 from vikramhh:unittests_junit_2

@thaJeztah
Copy link
Member Author

Looks like this PR didn't work, probably because I opened it directly from your fork.

I updated #39998 with those changes, but looks like it doesn't work yet (see my comments on that PR)

Let me close this one

@thaJeztah thaJeztah closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants