Dockerfile: move yamllint to its own stage, and update to 1.23.0 #40113
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
|
Ah, boo! Looks like |
thaJeztah
force-pushed
the
yamllint_stage
branch
from
9cf5979
to
076dd36
Compare
|
Okay; got arm64 working, but ppc64le and s390x are still failing. Looks like that's a known issue; pyinstaller/pyinstaller#2050 (comment) (same for docker compose; docker/compose#6133) |
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1.23.0 (2020-04-17) - Allow rules to validate their configuration - Add options extra-required and extra-allowed to quoted-strings 1.22.1 (2020-04-15) - Fix quoted-strings rule with only-when-needed on corner cases 1.22.0 (2020-04-13) - Add check-keys option to the truthy rule - Fix quoted-strings rule not working on sequences items - Sunset Python 2 1.21.0 (2020-03-24) - Fix new-lines rule on Python 3 with DOS line endings - Fix quoted-strings rule not working for string values matching scalars - Add required: only-when-needed option to the quoted-strings rule 1.20.0 (2019-12-26) - Add --no-warnings option to suppress warning messages - Use 'syntax' as rule name upon syntax errors 1.19.0 (2019-11-19) - Allow disabling all checks for a file with # yamllint disable-file 1.18.0 (2019-10-15) - Lint .yamllint config file by default - Also read config from .yamllint.yml and .yamllint.yaml - Improve documentation for yaml-files - Update documentation for pre-commit - Explicitly disable empty-values and octal-values rules 1.17.0 (2019-08-12) - Simplify installation instructions in the README - Add OpenBSD installation instructions - Make YAML file extensions configurable Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
```
Failed to build pyinstaller
Installing collected packages: altgraph, pyinstaller, pathspec, pyyaml, yamllint
Running setup.py install for pyinstaller: started
Running setup.py install for pyinstaller: finished with status 'error'
Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-05osqa8r/pyinstaller/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-8riizqk3-record/install-record.txt --single-version-externally-managed --compile --user --prefix=:
running install
running build
running build_bootloader
No precompiled bootloader found. Trying to compile it for you ...
Setting top to : /tmp/pip-build-05osqa8r/pyinstaller/bootloader
Setting out to : /tmp/pip-build-05osqa8r/pyinstaller/bootloader/build
Python Version : 3.5.3 (default, Sep 27 2018, 17:25:39) [GCC 6.3.0 2017051]
Checking for 'gcc' (C compiler) : /usr/bin/gcc
Checking size of pointer : 8
Platform : Linux-64bit detected based on compiler
Checking for program '/usr/bin/strip' : /usr/bin/strip
Checking for program 'strip' : /usr/bin/strip
Checking for library dl : yes
Checking for library m : yes
Checking for library z : not found
The configuration failed
(complete log in /tmp/pip-build-05osqa8r/pyinstaller/bootloader/build/config.log)
ERROR: Failed compiling the bootloader. Please compile manually and rerun setup.py
----------------------------------------
Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-05osqa8r/pyinstaller/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-8riizqk3-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-build-05osqa8r/pyinstaller/
ERROR: executor failed running [/bin/sh -c pip3 install --user pyinstaller yamllint==${YAMLLINT_VERSION} && /root/.local/bin/pyinstaller --onefile --distpath=/build /root/.local/bin/yamllint && /build/yamllint --version]: exit code: 1
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
yamllint_stage
branch
from
44a8431
to
e130c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the final stage a bit cleaner again