New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go-swagger to work with Go 1.14 #40523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template used was broken with Go 1.14, which has some stricter rules, introduced in https://golang.org/cl/206124 ``` root@b5beaed18589:/go/src/github.com/docker/docker# ./hack/generate-swagger-api.sh 2020/02/07 15:12:01 trying to read config from /go/src/github.com/docker/docker/api/swagger-gen.yaml 2020/02/07 15:12:02 rendering 1 templates for model ErrorResponse 2020/02/07 15:12:02 name field ErrorResponse 2020/02/07 15:12:02 package field types 2020/02/07 15:12:02 creating "error_response.go" in "api/types" as definition model: template: schematype:2:18: executing "schemaType" at <(len .AllOf) gt 0>: can't give argument to non-function len .AllOf ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
process/cherry-pick
area/project
kind/bugfix
PR's that fix bugs
labels
Feb 14, 2020
ping @SamWhited @kolyshkin @AkihiroSuda PTAL 🤗 |
LGTM |
tiborvass
approved these changes
Feb 14, 2020
bringing this one in |
Master tests do not like this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #40353
full diff: kolyshkin/go-swagger@5793aa6...5e6cb12
The template used was broken with Go 1.14, which has some stricter
rules, introduced in https://golang.org/cl/206124
This update includes the fix from kolyshkin/go-swagger#1. Opening this as a separate pull request, so that we can backport this to release branches to prepare them for future Go updates