New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream logging changes from Enterprise Edition #40543
Conversation
Nice!! Looks like you need to update the import path for gotest.tools (which now has a
|
Rebased with the import path change; waiting on CI to run again. |
This supplements any log driver which does not support reads with a custom read implementation that uses a local file cache. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit d675e2bf2b75865915c7a4552e00802feeb0847f) Signed-off-by: Madhu Venugopal <madhu@docker.com>
Configuration over the API per container is intentionally left out for the time being, but is supported to configure the default from the daemon config. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit cbecf48bc352e680a5390a7ca9cff53098cd16d7) Signed-off-by: Madhu Venugopal <madhu@docker.com>
Done. Also pushed a few linter / other package import fixes. Waiting on CI again to see if any tests actually need to be skipped. |
looks like it's mostly green; for Windows, I think we need an explicit "skip" in the integration test |
Interesting failure on ppc64
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Except I wrote the original code, so 🤷♂
See issue #40193 Signed-off-by: Sam Whited <sam@samwhited.com>
After this is merged, we need some update to the documentation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note for future users who might be surprised to find a it is possible to avoid the local copy of the logs by passing the (the file is rotated and a limit of 4 older files are kept, gzipped, so they're not huge) |
@jraby Huge? How big? |
I guess I spoke too soon, the file doesn't grow above ~20something mb before getting rotated and gzipped. |
@thaJeztah This documentation still claims that dual-logging is not available in Docker CE: https://docs.docker.com/config/containers/logging/configure/#limitations-of-logging-drivers EDIT: This documentation also says that this is an enterprise-only feature: https://docs.docker.com/config/containers/logging/dual-logging/ I am so confused. This blog post doesn't mention anything about being enterprise-only: https://www.docker.com/blog/introducing-docker-engine-20-10/ Is the documentation outdated or is this still an enterprise-only feature? |
@thaJeztah |
Hmm. not sure I fully understand your comment;
|
@thaJeztah , sorry that I wasn't so clear. |
I have questions about the 3rd case also. (Using a remote driver). I wanted to tune or configure the "log cache" settings to fit system better. Also I have docker swarm. Will this allow me to still call |
Is there an undocumented option to turn this off globally? |
You can set |
Sorry, |
@cpuguy83 I opened docker/cli#3052 and docker/cli#3052 - ptal (please double check if they can indeed be configured in combination with driver-specific options for the configured driver) |
fixes #30887
- What I did
git am ee-engine-pr-125.patch
ee-engine-pr-125.patch