New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Init=true by default on container create #40770
Conversation
This means any new containers, unless explicitly specified, created with API version 1.41 will have init enabled by default. This default can be controlled by the daemon-level `--init` setting. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
I feel this is too much "brave". This is likely to break containers with non-tini init. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, NOTLGTM
I understand it is pretty brave. Note that this does not change existing containers and only affects clients using the new API version. Also able to change this based on the value set in the daemon config. Given that we are not releasing a new version of Docker every quarter like we used to, I wonder if we can go ahead and make changes like this and make sure it's well documented in the release notes. |
Changes in the default behavior may cause confusion, or under certain circumstances will break the working logic of some containers.(may be some specific hack) But I think we should move forward. +1 for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the right move.
LGTM (except this needs a rebase -- @cpuguy83)
I think this should be enabled only if the image has LABEL=com.docker.image.default.init=true |
This seems too controversial so closing. |
This means any new containers, unless explicitly specified, created with
API version 1.41 will have init enabled by default. This default can be
controlled by the daemon-level
--init
setting.