New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-connections for TLS 1.3 support #41042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
left one suggestion; @SamWhited let me know if you think that's a good idea; not a blocker, so otherwise "good to go"
@thaJeztah good idea, merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we'll revendor once v0.5.0 was tagged, but don't think we have to wait for that 👍
Why is Windows RS5 failing? Weird;
|
Fixes #40495 Signed-off-by: Sam Whited <sam@samwhited.com>
Pushed a new version with the fixes @tiborvass just merged. I feel like I've seen that RS5 error a few times now, but I don't remember why. Let's see if it happens again when this CI run completes. |
Yes, so somehow it seems to be running tests against an older daemon, but with a current version of the CLI (which is.. odd), and not performing API version negotiation. Definitely need to keep an eye on it. Also on this PR to make sure it's not a regression in this package (I was about to tag v0.5.0, but then thought; let's first get this merged and tag later) |
Looks like it's still failing on Windows. The failure originates from this part of the code; moby/testutil/environment/environment.go Lines 47 to 51 in 5bf33ad
The client there is setup using this code moby/testutil/environment/environment.go Lines 36 to 39 in 5bf33ad
It looks like API version negotiation isn't working (but only on Windows?), or is it because the integration tests on Windows are running on the host? |
giving #41084 a test (still not sure why this worked before, and not in this PR) |
@SamWhited @AkihiroSuda did some more digging in #41084 (see comments I left there) |
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This restores the deprecated Transport.Dial, which were removed in commits: - 61039d0 (Replace deprecated Transport.Dial with Transport.DialContext) - fb772cf (Fix problems introduced by 61039d0) While we should still look at removing these, the moby code currently looks to be depending on their behavior. Removing them caused CI to fail, which blocked us from updating to the current version of this package. With those changes, Windows clients in CI were connecting with the wrong daemon, causing CI failures: Failed failed to get info from daemon: Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.40 exit status 1 FAIL github.com/docker/docker/integration/build 0.219s More details on moby/moby#41042 and moby/moby#41084 This patch restores the deprecated parts, but keeps the new variants as well, so that we can perform the migration in Moby when possible (after which they can be removed again) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
See #40495