Add option to supply docker cli from image #41086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use whatever cli you want. I was just going to have it build whatever CLI from docker/cli, but since the build scripts change over time, I couldn't even get it to build what we currently use in CI (17.06.2).... all just really annoying. So I decided we could just let people supply an image with the CLI in it. It needs to be in /build Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
We already have |
|
That only fetches precompiled binaries. |
|
Going to close this since its ancient and we should be able to do this with source policies now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use whatever cli you want.
I was just going to have it build whatever CLI from docker/cli, but since the build scripts change over time, I couldn't even get it to build what we currently use in CI (17.06.2).... all just really annoying.
So I decided we could just let people supply an image with the CLI in it. It needs to be in
/build