New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] archive: LCOW refactor (rebased) #41294
Conversation
What's the goal of this PR? IIUC we are going to remove LCOW codes after this refactoring? |
I was mostly curious how much work was left to get this finished, as it removed quite some code (so less to maintain?). As to removing LCOW; that mostly depends on how much bandwidth we have to work on that. I opened #40766 some time back to allow disabling the functionality, after which if could be possible to start working on removing it. ISTR there were still some uses of LCOW by Microsoft, but if they want the functionality to remain, I guess some help would be needed to maintain the code. |
These are the failures;
|
3d52ef5
to
6963ca3
Compare
Deletes lot of dead code in the process. TODO: fix tests that relied on those functions/types. Signed-off-by: Tibor Vass <tibor@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Tibor Vass <tibor@docker.com>
6963ca3
to
aacd97d
Compare
rebase of #39386, relates to #39533. Just rebased to see where/how this failed, as CI logs were gone
Big refactor with containerfs to remove duplicate code from LCOW
Deletes lot of dead code in the process.
TODO: fix tests that relied on those functions/types.