Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -t in docker stop and restart to choose grace period #415

Merged
merged 2 commits into from
Apr 19, 2013

Conversation

vieux
Copy link
Contributor

@vieux vieux commented Apr 16, 2013

Fixes #261

@creack
Copy link
Contributor

creack commented Apr 16, 2013

why "-s" ? second?
Wouldn't it be beter -t or even better -timeout?

@vieux
Copy link
Contributor Author

vieux commented Apr 17, 2013

Yes you're right, I prefer to keep small flags with the current flag system.

I'll update to -t asap

@vieux
Copy link
Contributor Author

vieux commented Apr 17, 2013

@creack done (I edited the commit ;) )

@shykes
Copy link
Contributor

shykes commented Apr 17, 2013

Tests don't pass, I'm guessing because of the prototype change in Container.Stop

creack added a commit that referenced this pull request Apr 19, 2013
added -t in docker stop and restart to choose grace period
@creack creack merged commit e92c4b1 into master Apr 19, 2013
@creack creack deleted the 261-choose_grace_period-feature branch April 19, 2013 19:42
@vieux
Copy link
Contributor Author

vieux commented Jun 12, 2013

Related to #230

dperny pushed a commit to dperny/docker that referenced this pull request Oct 18, 2021
…9.03-96e086dc332d2532514d466605cdbfc5fbb042ce

[19.03] sync to upstream 19.03 96e086d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce grace period of 'docker stop' - 10 seconds is too long
3 participants