daemon/graphdriver: don't unmount graphdriver root #41903
Draft
+68
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
area/storage/aufs
area/storage/devicemapper
area/storage
area/storage/overlay
status/2-code-review
kind/enhancement
Most graphdrivers no longer re-mount the graphdriver root, so we should not try to unmount the root itself, to allow users to mount a custom storage location at the graphdriver's root. Some exceptions: - BTRFS looks to still do a remount; https://github.com/moby/moby/blob/v20.10.2/daemon/graphdriver/btrfs/btrfs.go#L86-L90 - Devicemapper's "shutdown" function calls "unmountAndDeactivateAl()", which unmounts all mounts https://github.com/moby/moby/blob/v20.10.2/daemon/graphdriver/devmapper/deviceset.go#L2245-L2277 NOTE: Perhaps no unmounting is needed at all, looking at; - commit 3609b05 (scoped "makeprivate" to graphdriver root only) - commit 9803272 (removed the "makeprivate") Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on moby/sys#62
fixes #39267
Most graphdrivers no longer re-mount the graphdriver root, so we should not try to unmount the root itself, to allow users to mount a custom storage location at the graphdriver's root.
Some exceptions:
all mounts https://github.com/moby/moby/blob/v20.10.2/daemon/graphdriver/devmapper/deviceset.go#L2245-L2277
NOTE: Perhaps no unmounting is needed at all, looking at;
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)