Resume healthcheck when daemon restarts

[m-k8s]

Call updateHealthMonitor for alive non-paused containers when daemon restarts.

What I did

Fix issue #41871 feat. @ealessandria-orange

- How I did it

While dockerd restores, call updateHealthMonitor for non paused alive containers.

- How to verify it

At dockerd restart, containers' healthcheck is still running.

- Description for the changelog

Fix issue #41871

[thaJeztah]

Probably could use a test as well; I see there's a test for restarting the daemon that's already testing some scenarios with live-restore enabled;

moby/integration/container/restart_test.go

Line 16 in 46cdcd2

func TestDaemonRestartKillContainers(t *testing.T) {

[thaJeztah]

Looks like CI is failing (seeing some panics)

[m-k8s]

CI job "ppc64le" doesn't pass, I don't think it's coming from my code, @thaJeztah can you look at it please?

[thaJeztah]

I kicked CI to run again 👍

[m-k8s]

I kicked CI to run again 👍

Thank you, but the job "ppc64le" failed again, the error says that it cannot delete some files (operation not allowed).
Can you try to manually delete this folder /home/docker/workspace/moby_PR-41935/ on the "ppc64le" jenkins node please?

[m-k8s]

@thaJeztah I think Jenkins is looking to delete the directory because I force-pushed the e1973f1 commit two days ago.
I sent this forced push because I had "amended" a commit to correct a piece of code, it's a bad habit, I should have made another commit, sorry.

[cpuguy83]

LGTM

[thaJeztah]

could you squash the commits? (let me know if you need help doing so)

[m-k8s]

could you squash the commits? (let me know if you need help doing so)

Thanks, I would click on the "squash and merge" button.

I cannot start the merge because the integration test did not pass.

[cpuguy83]

We cannot use squash and merge due to dco signing requirements.

[cpuguy83]

It also doesn't use a merge commit in that case.

[m-k8s]

The commits squash is done.

[cpuguy83]

@alexisries Thanks, we'll merge once review is complete.

[cpuguy83]

Note that this is fixing a bug in that one cannot restart a daemon with live-restore and also have healthchecks.

[tianon]

LGTM 😅

[thaJeztah]

LGTM, thanks!

[thaJeztah]

Failures are the known failures from #42892 - ignoring those