Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test daemon logging #42138

Merged
merged 1 commit into from Jul 9, 2023
Merged

Improve test daemon logging #42138

merged 1 commit into from Jul 9, 2023

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Mar 11, 2021 •
edited by thaJeztah

  1. On failed start tail the daemon logs
  2. Exposes generic tailing functions to make test debugging simpler

thaJeztah
thaJeztah approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

close/reopen to trigger CI (logs were pruned)

@thaJeztah thaJeztah closed this Apr 20, 2021
@thaJeztah thaJeztah reopened this Apr 20, 2021
@cpuguy83
Improve test daemon logging
914888c 
1. On failed start tail the daemon logs
2. Exposes generic tailing functions to make test debugging simpler

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Copy link
Member Author

cpuguy83 commented Jul 5, 2023

Rebased this.

@cpuguy83 cpuguy83 requested a review from neersighted July 5, 2023 23:20
thaJeztah
thaJeztah approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@neersighted @corhere ptal

@thaJeztah thaJeztah added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Jul 9, 2023
@thaJeztah thaJeztah added this to the 25.0.0 milestone Jul 9, 2023
@thaJeztah thaJeztah merged commit 49b55b2 into moby:master Jul 9, 2023
102 checks passed
This was referenced Aug 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neersighted neersighted neersighted approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon Awaiting requested review from tianon

Assignees
No one assigned
Labels
area/testing kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. process/cherry-picked status/2-code-review
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpuguy83 @thaJeztah @neersighted