-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-winio package to latest version #42307
Conversation
Heads up; this will conflict with #42270 (once merged) |
Looks like there's a breaking change in this version of go-winio
Looking at the diff since v0.4.16 (which is green in #42270); microsoft/go-winio@v0.4.16...v0.4.18 I think this is the one that causes the failure; microsoft/go-winio#185 Looks like that change requires an updated version of hcsshim (with microsoft/hcsshim#947) and containerd as well |
Hmm, this one's going to be a little tricky to unwind: The removal of the forked go-winio/backuptar (in containerd) where this compile failure is happening (containerd/containerd#4395) is only in containerd 1.5.0. The API change in question is in go-winio 0.4.17, (microsoft/go-winio@bfd5468) which is also where the fix I assume we're trying to get (microsoft/go-winio@83fd176) shipped. hcsshim itself hit this problem in its integration test suite (microsoft/hcsshim#946) and ended up pulling containerd 1.5 beta in order to unblock go-winio upgrades: microsoft/hcsshim#946
where "that deduplicated" (sic) means containerd/containerd#4395. hcsshim itself isn't using these APIs, but newer containerd I'm actually somewhat surprised this has occurred, because I thought moby/moby didn't use this code, providing its own GraphDriver instead, Anyway, some options:
Of those, I would prefer the new containerd 1.4.x release. containerd/containerd#4395 was originally prepared and tested against containerd 1.4.0-beta.2 (it just took a while to be merged) so I expect no problems with doing that. It's also the most-pain to co-ordinate though. A new hcsshim 0.4.x release would be my second preference, but again, takes co-ordination. The other options can be done unilaterally here. |
@TBBle I'll be working on option 3 (Revert the two FileInfo commits in go-winio, release a new 0.4.x version, and then unrevert them to start the 0.5 series) today. |
for easier finding: pull request for the above is microsoft/go-winio#204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@awmirantis could you squash the commits? |
Signed-off-by: Adam Williams <awilliams@mirantis.com>
continued in #42327 |
Signed-off-by: Adam Williams awilliams@mirantis.com
Update Microsoft/go-winio to latest version. A change in this version is needed for a future fix to using docker data root on a VHDX.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)