Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile: skip ppc64le and s390x by default on pull requests #42374

Merged
merged 1 commit into from May 12, 2021

Conversation

thaJeztah
Copy link
Member

This changes CI to skip these platforms by default. The ppc64le and s390x
machines are "pet machines", configuration may be outdated, and these
machines are known to be flaky.

Building and verifying packages for these platforms is being handed
over to the IBM team.

We can still run these platforms for specific pull requests by selecting
the checkboxes.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This changes CI to skip these platforms by default. The ppc64le and s390x
machines are "pet machines", configuration may be outdated, and these
machines are known to be flaky.

Building and verifying packages for these platforms is being handed
over to the IBM team.

We can still run these platforms for specific pull requests by selecting
the checkboxes.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 but also fully understandable and +1

LGTM

@AkihiroSuda AkihiroSuda merged commit b9071dc into moby:master May 12, 2021
@thaJeztah thaJeztah deleted the disable_power_z branch May 18, 2021 07:56
@thaJeztah
Copy link
Member Author

😢 but also fully understandable and +1

We could re-enable them at some point (there definitely are some things to look into (e.g. need to have another look into #42231)

Current reality though, was that most of the time we would either ignore the failures, "skip" these ("build with parameters"), or repeatedly run Jenkins "until it goes green", which was a waste of time IMO.

We could probably add a stage that just builds the binaries (to make sure it "compiles"), or make sure that our cross target also builds for these

@tianon
Copy link
Member

tianon commented May 18, 2021

Yeah, totally sane -- maybe instead of doing them on every PR we have a separate "master only" build that runs them so they're still being run and folks can look at them if they want to help contribute to making sure they're supported but they aren't holding us up on PRs? hahahahaha, that's literally what this PR does. I'm so good. 🤦

(100% on board with at least a compilation check for any architecture we "support" even if that support only amounts to "it builds")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants