distribution: fix multi-arch Windows image preference

[fsiegmund]

Signed-off-by: fsiegmund siegmund@slb.com

- What I did

Changes in pull_vs2_windows.go:

• Fix Multi-arch: Windows image pull does not pull best match #42423: prefer UBR match, if exists
• Resolved "TODO: Split version by parts and compare"
• Resolved "TODO: Prefer versions which have a greater version"

- How I did it

Change sorting logic of image, using comparable image versions. Images that exactly match host OS version will be moved to the top, followed by versions that match host build, in descending order.

- How to verify it

See #42423. Create multi arch image and pull. The image with exact host version will be preferred. Otherwise as logic above.

- Description for the changelog

• consider UBR in Windows multi-arch image pull

- A picture of a cute animal (not mandatory but encouraged)

ฅ ̳͒•ˑ̫• ̳͒ฅ

[thaJeztah]

@crazy-max @tonistiigi ptal

We were discussing this in the maintainers meeting, and want to look if this code should possibly be in the containerd package (so that there's a more central / canonical place where the matching behaviour is defined)

[frs3]

Sounds good! Do you expect me to move it?

…

On Thu, 20 Jan 2022, 19:42 Sebastiaan van Stijn, ***@***.***> wrote: @crazy-max <https://github.com/crazy-max> @tonistiigi <https://github.com/tonistiigi> ptal We were discussing this in the maintainers meeting, and want to look if this code should possibly be in the containerd package (so that there's a more central / canonical place where the matching behaviour is defined) — Reply to this email directly, view it on GitHub <#42425 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABARCCYFCPNOQJYMJLLQBSTUXBQQ5ANCNFSM45SDNOYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[thaJeztah]

I kept forgetting to comment (and didn't come round to looking closely at the changes ☺️), but it came up in a discussion, and I know @tonistiigi and @crazy-max were working on some changes in containerd in this area, so O was hoping they would be able to assist.

If possible, yes, I think this code would ideally live in containerd, but (as mentioned) I haven't had a close look to see if it's easy to move it there (and then consume it in this repository as vendored code), but if you have time to look doing so, that would be great!