(v2) cmd: dockerd: make systemd specific cgroups tweaks build-time optional #42431
+38
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For future updates; could you update your existing PR instead of opening a new one? |
sorry, didn't know that this is possible at all. |
|
Yes, adding commits, or amending commits and force-push will update PRs |
|
Does this reduce binary footprint? |
Yes, it does. not much, but it does. |
|
Actual data? |
metux
force-pushed
the
submit/optional-systemd-cgroups-v2
branch
3 times, most recently
from
b9f5b5e
to
14bc234
Compare
metux
force-pushed
the
submit/optional-systemd-cgroups-v2
branch
6 times, most recently
from
d9c64fe
to
dea1879
Compare
When running under systemd, we have to do some tweaks for systemd's
non standard cgroups setups. This isn't required if we'll never be running
in such an environment (eg. there're many distros free of such Lennartisms).
Therefore make it possible to opt out at build time by settings the
'no_systemd' tag.
changes v2: fixed danling import
renamed 'nosystemd' tag to 'no_systemd'
dropped old build tags
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
submit/optional-systemd-cgroups-v2
branch
from
dea1879
to
19f8fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under systemd, we have to do some tweaks for systemd's
non standard cgroups setups. This isn't required if we'll never be running
in such an environment (eg. there're many distros free of such Lennartisms).
Therefore make it possible to opt out at build time by settings the
'no_systemd' tag.
changes v2: fixed danling import
renamed 'nosystemd' tag to 'no_systemd'
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)