Use containerd OCI defaults where possible #42485
Draft
+19
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
the
status/failing-ci
Inspired by comments in the equivalent function in containerd Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
annotate_default_devices
branch
from
21dd604
to
48e36b0
Compare
There are some differences between docker and containerd: Docker: "" false rwm // what does this do? default permissions on `/dev`? "/dev/console" true rwm "/dev/null" true rwm "/dev/random" true rwm "/dev/tty" true rwm "/dev/urandom" true rwm "/dev/zero" true rwm "fuse" false rwm In docker, `/dev/pts` is specified as mount (spec.Mounts) Containerd: "/dev/console" true rwm "/dev/full" true rwm "/dev/null" true rwm "/dev/ptmx" true rwm // /dev/ptmx -> /dev/pts/ptmx - pts namespaces are "coming soon" "/dev/pts/" true rwm // pts namespaces are "coming soon" "/dev/random" true rwm "/dev/tty" true rwm "/dev/urandom" true rwm "/dev/zero" true rwm "tuntap" true rwm Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
annotate_default_devices
branch
from
48e36b0
to
cc5dad9
Compare
|
Opened containerd/containerd#6923 to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some differences between docker and containerd:
Had this branch still around, and realised I didn't push it
Docker:
In docker,
/dev/ptsis specified as mount (spec.Mounts)Containerd: