don't use buildmode=pie on ppc64 #42514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Does Go not support this build mode on ppc64? |
it does not on big-endian ppc64. |
samuelkarp
reviewed
Jun 11, 2021
gyakovlev
force-pushed
the
ppc64-buildmode
branch
from
c4135e3
to
11cb1db
Compare
|
oops, I rebased too much. will fix soon. |
It's already omitted for ppc64 in hack/dockerfile/install/install.sh not using wildcard, because GOARCH=ppc64le supports pie Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
gyakovlev
force-pushed
the
ppc64-buildmode
branch
from
11cb1db
to
2cd68d5
Compare
|
CI failure appears to be another instance of #42459 |
AkihiroSuda
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
made sure
buildmode=pieis not passed on ppc64 (big-endian)- How I did it
added exception in
hack/make/.binaryIt's already omitted for ppc64 in
hack/dockerfile/install/install.shnot using wildcard, because GOARCH=ppc64le supports pie
- How to verify it
apply provided patch and #42172
docker now builds and works on big-endian ppc64
- Description for the changelog
don't pass buildmode=pie on ppc64be
- A picture of a cute animal (not mandatory but encouraged)