New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkinsfile: also run unit-tests on rootless #42740
base: master
Are you sure you want to change the base?
Conversation
Not all of our unit tests are fully "unit", and some may depend on the environment in which they're running, so let's also run these in the rootless stage of our Jenkinsfile. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Looks like the fuse-overlayfs tests are skipped on rootless (probably something we should fix, if possible);
Also skipping some overlay/overlay2 tests (do we need those?)
We need to check if these are running elsewhere;
|
stage("Unit tests") { | ||
environment { | ||
DOCKER_ROOTLESS = '1' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think this env is consumed by unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can execute rootlesskit go test
in hack/make/unit when this env var is set.
rootlesskit flags could be copied from dockerd-rootless.sh
Not all of our unit tests are fully "unit", and some may depend on the
environment in which they're running, so let's also run these in the
rootless stage of our Jenkinsfile.
- A picture of a cute animal (not mandatory but encouraged)