Create pkg/system and move stuff there from archive #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crosbymichael will this conflict with your branch ? |
| import "syscall" | ||
|
|
||
| func getLastAccess(stat *syscall.Stat_t) syscall.Timespec { | ||
| return stat.Atimespec |
There was a problem hiding this comment.
This will probably not compile on darwin and BSD. You might want to return an empty Timespec or even better return am error when it is not supported
kzys
added a commit
to kzys/docker
that referenced
this pull request
Feb 28, 2014
|
Yep, it does not conflict . |
|
Running ---> Making bundle: cross (in bundles/0.8.1-dev/cross)
Created symlinks: /go/src/github.com/dotcloud/docker/bundles/0.8.1-dev/cross/linux/amd64/docker-0.8.1-dev
Created binary: /go/src/github.com/dotcloud/docker/bundles/0.8.1-dev/cross/linux/386/docker-0.8.1-dev
Created binary: /go/src/github.com/dotcloud/docker/bundles/0.8.1-dev/cross/linux/arm/docker-0.8.1-dev
# github.com/dotcloud/docker/pkg/system
pkg/system/utimes_unsupported.go:8: undefined: ErrNotImplemented
pkg/system/utimes_unsupported.go:12: undefined: ErrNotImplemented
pkg/system/xattrs_unsupported.go:5: imported and not used: "syscall"
pkg/system/xattrs_unsupported.go:8: undefined: ErrNotImplemented
pkg/system/xattrs_unsupported.go:12: undefined: ErrNotImplemented |
|
ping @alexlarsson |
This is a package for generic system calls etc that for some reason is not yet supported by "syscall", or where it is different enough for the different ports to need portability wrappers. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
|
New version passes make cross |
|
LGTM ping @creack @crosbymichael @vieux |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Mar 5, 2014
Create pkg/system and move stuff there from archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a package for generic system calls etc that for some reason
is not yet supported by "syscall", or where it is different enough
for the different ports to need portability wrappers.
Docker-DCO-1.1-Signed-off-by: Alexander Larsson alexl@redhat.com (github: alexlarsson)
One reason for this other than pure cleanup is that the overlayfs backend also needs a bunch of these calls.