make docker build -rm=true default

[cpuguy83]

Fixes part of #4291

Docker-DCO-1.1-Signed-off-by: Brian Goff cpuguy83@gmail.com (github: cpuguy83)

[tianon]

+9001 yesplz

[jamtur01]

Definitely needs a docs update to make this very clear. Otherwise +1.

[cpuguy83]

Wasn't sure if there was a doc for this or not.

[jamtur01]

The cli.rst doc for sure and perhaps the Docker build docs.

[jamtur01]

http://docs.docker.io/en/latest/reference/commandline/cli/#build

[jamtur01]

http://docs.docker.io/en/latest/reference/builder/

[cpuguy83]

When -rm is passed in, if the default is true does it set it to false or would it have to be docker build -rm=false ?

[cpuguy83]

Updated docs.

[jamtur01]

Docs LGTM /cc @metalivedev @SvenDowideit

[tianon]

Hmm, if "true" becomes the default, shouldn't we instead just remove --rm from the invocation, so our examples get even simpler?

[cpuguy83]

I thought about that...
But the doc is showing off what -rm does, not that it's default.

But either way is fine.

[tianon]

Ahh ok, that makes sense. :)

[tianon]

@cpuguy83 would you be willing to add the following patch to this, too? :)

diff --git a/Makefile b/Makefile
index e124d1d..e15ed35 100644
--- a/Makefile
+++ b/Makefile
@@ -32,10 +32,10 @@ shell: build
        $(DOCKER_RUN_DOCKER) bash

 build: bundles
-       docker build -rm -t "$(DOCKER_IMAGE)" .
+       docker build -t "$(DOCKER_IMAGE)" .

 docs-build:
-       docker build -rm -t "$(DOCKER_DOCS_IMAGE)" docs
+       docker build -t "$(DOCKER_DOCS_IMAGE)" docs

 bundles:
        mkdir bundles

(ie, remove -rm from our Makefile)

[SvenDowideit]

LGTM - tho I think this needs to be in the Changelog to try to alert the old hands that life is different now

[tianon]

Uh, the "run" lines in the Makefile still need -rm :)

[cpuguy83]

Whoops! See, you should have done a PR :)

[cpuguy83]

Fixed.

[tianon]

:) LGTM

[cpuguy83]

@SvenDowideit Is this something I need to do or is there someone that maintains this?

[tianon]

That's up to the release maintainer. :)

[creack]

LGTM /cc @vieux @unclejack

[crosbymichael]

LGTM

[crosbymichael]

ping @shykes @vieux

This is an external change for the user, does it LG to you?

[vieux]

It's ok for me

On Mon, Feb 24, 2014 at 11:26 AM, Michael Crosby
notifications@github.comwrote:

ping @shykes https://github.com/shykes @vieux https://github.com/vieux

This is an external change for the user, does it LG to you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/4292#issuecomment-35924722
.

Victor VIEUX
http://vvieux.com

[shykes]

If we're going to make it the default, I think we should hide it from any docs and examples other than the most advanced. Reduce the cognitive load.

Otherwise I agree with the change.

[SvenDowideit]

@cpuguy83 I'd be thrilled if you updated the docs :) but if you don't want to, I'm willing to do it in a separate PR

[cpuguy83]

I made the doc change, let me know if this is sufficient.

[unclejack]

It should be effect here.

[cpuguy83]

Ugh... grammar... I still want to say this should be affect.
If -rm affected the build the result would be an effect ?

Or perhaps "This has no impact on the build cache"

[unclejack]

It should be something like This doesn't affect the build cache. if you want to stick to using affect.

[cpuguy83]

Ok, it's updated.

Thanks.

[unclejack]

LGTM