fix TestInvalidRemoteDriver() to check underlying error #42966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b1a3fe4 changed how the error was returned (which is now wrapped), causing the test to fail: === RUN TestInvalidRemoteDriver libnetwork_test.go:1289: Did not fail with expected error. Actual error: Plugin does not implement the requested driver: plugin="invalid-network-driver", requested implementation="NetworkDriver" --- FAIL: TestInvalidRemoteDriver (0.01s) Changing the test to use errors.Is() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/testing
area/plugins
kind/bugfix
|
@AkihiroSuda @cpuguy83 PTAL |
cpuguy83
approved these changes
Oct 25, 2021
AkihiroSuda
approved these changes
Oct 25, 2021
|
Failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit b1a3fe4 (#41215) changed how the error was
returned (which is now wrapped), causing the test to fail:
Changing the test to use errors.Is()
- A picture of a cute animal (not mandatory but encouraged)