integration-cli: remove manifest v2 schema 1 push tests #43029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing manifest v2, schema 1 images has been deprecated in commit 6302dbb (docker 20.10). It's still used in some tests to provision a legacy registry to test _pulling_ legacy images (which is still "supported"), but we should no longer have to validate pushing for other scenarios. This patch removes the schema 1 push tests, and inlines the code that was extracted in non-exported functions (for them to be shared between schema 2 and schema 1 tests). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
justincormack
approved these changes
Nov 18, 2021
|
Bringing this one in; CI failures are "related" but false detection of "new tests added to integration-cli" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing manifest v2, schema 1 images has been deprecated in commits 4866f51 (#39365) and 6302dbb (#41295) (docker 20.10). While it's still used in some tests to provision a legacy registry to test pulling legacy images (which is still "supported"), we should no longer have to validate pushing for other scenarios.
This patch removes the schema 1 push tests, and inlines the code that was extracted in non-exported functions (for them to be shared between schema 2 and schema 1 tests).
Relates to:
- A picture of a cute animal (not mandatory but encouraged)