Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixing /exec/{id}/resize response code in API documentation #43137

Merged
merged 1 commit into from Jan 11, 2022
Merged

docs: fixing /exec/{id}/resize response code in API documentation #43137

merged 1 commit into from Jan 11, 2022

Conversation

thaJeztah
Copy link
Member

This takes the changes from 1a933e1 and 834272f (#43122), and applies them to older API versions in the docs directory (which are used for the actual documentation).

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
docs: fixing /exec/{id}/resize response code in API documentation
2145f3b 
This takes the changes from 1a933e1 and
834272f, and applies them to older API
versions in the docs directory (which are used for the actual documentation).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tianon
tianon approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(CI failure looks like just a Windows flake -- definitely unrelated to this change)

@thaJeztah
Copy link
Member Author

Yes, known flaky (but looks to have become more flaky again over time); #43012

=== RUN   TestDockerSuite/TestSlowStdinClosing
    docker_cli_run_test.go:4177: assertion failed: error is not nil: exit status 127
    --- FAIL: TestDockerSuite/TestSlowStdinClosing (1.06s)

@thaJeztah
Copy link
Member Author

Let me bring this one in

@thaJeztah thaJeztah merged commit 92a6bed into moby:master Jan 11, 2022
@thaJeztah thaJeztah deleted the update_swagger_docs branch January 11, 2022 15:13
@thaJeztah thaJeztah added this to the 21.xx milestone Jan 14, 2022
@thaJeztah thaJeztah mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

Assignees
No one assigned
Labels
area/api area/docs process/cherry-picked status/3-docs-review
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thaJeztah @tianon @samuelkarp