Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/request.go:157:8: SA1019: err.Temporary is deprecated (staticcheck) #43202

Merged
merged 1 commit into from
Feb 8, 2022
Merged

client/request.go:157:8: SA1019: err.Temporary is deprecated (staticcheck) #43202

merged 1 commit into from
Feb 8, 2022

Conversation

thaJeztah
Copy link
Member

relates to #43194 #43194 (comment)

It's deprecated in Go 1.18:

client/request.go:157:8: SA1019: err.Temporary is deprecated: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method. (staticcheck)
    if !err.Temporary() {
        ^

@thaJeztah
client/request.go:157:8: SA1019: err.Temporary is deprecated (staticc…
2cff05e 
…heck)

It's deprecated in Go 1.18:

    client/request.go:157:8: SA1019: err.Temporary is deprecated: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method. (staticcheck)
        if !err.Temporary() {
            ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jan 31, 2022
Merged
3 tasks
@thaJeztah
Copy link
Member Author

Flaky test, or could this be related to the change?

=== RUN   TestWaitNonBlocked/wait-nonblocking-exit-0
=== PAUSE TestWaitNonBlocked/wait-nonblocking-exit-0
=== CONT  TestWaitNonBlocked/wait-nonblocking-exit-0
=== CONT  TestWaitNonBlocked/wait-nonblocking-exit-0
    wait_test.go:42: assertion failed: error is not nil: Error response from daemon: hcsshim::PrepareLayer - failed failed in Win32: The device is not ready. (0x15)
    --- FAIL: TestWaitNonBlocked/wait-nonblocking-exit-0 (60.17s)

@thaJeztah
Copy link
Member Author

Failure on Windows is a known flaky test TestStartReturnCorrectExitCode (#38521)

=== RUN   TestDockerSuite/TestStartReturnCorrectExitCode
    docker_cli_start_test.go:209: assertion failed: expected an error, got nil
    --- FAIL: TestDockerSuite/TestStartReturnCorrectExitCode (10.22s)

@tianon tianon merged commit 9bf647c into moby:master Feb 8, 2022
@thaJeztah thaJeztah deleted the skip_temporary_error_check branch February 8, 2022 08:41
@thaJeztah thaJeztah mentioned this pull request Feb 8, 2022
Merged
2 tasks
@thaJeztah thaJeztah added this to the 21.xx milestone Feb 18, 2022
@thaJeztah thaJeztah mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@justincormack justincormack justincormack approved these changes

Assignees
No one assigned
Labels
area/api process/cherry-picked status/2-code-review
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thaJeztah @tianon @justincormack