testing: remove some defer cleanup in favor of test.Cleanup() #43340
+0
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
This comment was marked as resolved.
This comment was marked as resolved.
thaJeztah
commented
Mar 7, 2022
thaJeztah
force-pushed
the
testing_remove_defers
branch
from
d52fe2d
to
1a1e96b
Compare
tianon
approved these changes
Mar 8, 2022
|
Yeah, so |
thaJeztah
force-pushed
the
testing_remove_defers
branch
from
1a1e96b
to
2c6c9b7
Compare
tianon
approved these changes
Apr 29, 2022
thaJeztah
force-pushed
the
testing_remove_defers
branch
from
2c6c9b7
to
91351f9
Compare
gotest.tools v3.0.1 and up support Go's native test.Cleanup(), which means that manually calling the cleanup functions in a defer is no longer needed. Some of these could probably be replaced by Go's native `t.TempDir()`, but keeping that for a follow-up exercise. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
testing_remove_defers
branch
from
91351f9
to
8b44af0
Compare
tianon
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gotest.tools v3.0.1 and up support Go's native test.Cleanup(), (see gotestyourself/gotest.tools#180) which means that manually calling the cleanup functions in a defer is no longer needed.
Some of these could probably be replaced by Go's native
t.TempDir(), but keeping that for a follow-up exercise.- A picture of a cute animal (not mandatory but encouraged)