Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing windows arm64 arch detection #43475

Merged
merged 1 commit into from Apr 10, 2022
Merged

missing windows arm64 arch detection #43475

merged 1 commit into from Apr 10, 2022

Conversation

crazy-max
Copy link
Member

encountered this issue in #43431 (comment)

- What I did

fix windows arm64 arch detection:

time="2022-04-09T12:22:20-07:00" level=error msg="Could not read system architecture info: Unknown processor architecture"
time="2022-04-09T12:22:20.960012400-07:00" level=info msg="Starting up"
time="2022-04-09T12:22:20.964046500-07:00" level=info msg="Windows default isolation mode: hyperv"

- How to verify it

$ DOCKER_CROSSPLATFORMS=windows/arm64 hack/make.sh cross

On a Windows arm64 capable system:

> dockerd-dev.exe --debug
time="2022-04-09T12:22:20.960012400-07:00" level=info msg="Starting up"
...

- Description for the changelog

fix windows arm64 arch detection

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max
missing windows arm64 arch detection
5d9e99e 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@samuelkarp
Copy link
Member

Jenkins test failures are known flakes; #39352 and #42459. Re-running CI.

@crazy-max
Copy link
Member Author

Thanks @samuelkarp :)

samuelkarp
samuelkarp approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 22.04.0 milestone Apr 10, 2022
thaJeztah
thaJeztah approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit c687298 into moby:master Apr 10, 2022
@crazy-max crazy-max deleted the win-arm64 branch April 10, 2022 18:50
@thaJeztah thaJeztah mentioned this pull request Apr 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazy-max @samuelkarp @thaJeztah