Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swarmkit to v2 #43515

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Bump swarmkit to v2 #43515

merged 1 commit into from
Apr 28, 2022

Conversation

corhere
Copy link
Contributor

@corhere corhere commented Apr 21, 2022

- What I did
Finished what I started with moby/swarmkit#3061

- How I did it
s|"github.com/docker/swarmkit|"github.com/moby/swarmkit/v2|g all .go files outside of the vendor tree (but with VSCode's search and replace, which automatically reformats all touched files)

There was some dependency hell with transitive dependencies and our good friend etcd, but pinning the version of github.com/google/certificate-transparency-go did the trick. A manual upgrade of github.com/opencontainers/image-spec was also required as otherwise go mod tidy would "upgrade" that module to v1.0.2, which lacked a definition that the currently-vendored version of buildkit depends on.

- How to verify it
CI

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Cory Snider <csnider@mirantis.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

failure was unrelated (kicked CI again)

@tianon @ndeloof @dperny PTAL

@thaJeztah thaJeztah merged commit 647aede into moby:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants