Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: set default "Builder-Version" to "2" (BuildKit) on Linux #43657

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

thaJeztah
Copy link
Member

Starting with the 22.06 release, buildx is the default client for
docker build, which uses BuildKit as builder.

This patch changes the default builder version as advertised by
the daemon to "2" (BuildKit), so that pre-22.06 CLIs with BuildKit
support (but no buildx installed) also default to using BuildKit
when interacting with a 22.06 (or up) daemon.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Hmmm... github actions having issues, or is it a networking issue inside the Dockerfile?

WARNING: MSG:UnableToDownload 
«https://go.microsoft.com/fwlink/?LinkID=627338&clcid=0x409» «»
WARNING: Unable to download the list of available providers. Check your 
internet connection.
Install-Package : No match was found for the specified search criteria and 
package name '7Zip4PowerShell'. Try Get-PackageSource to see all available 
registered package sources.
At line:1 char:3109
+ ... ownloading containerd; Install-Package -Force 7Zip4PowerShell; $locat ...
+                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPacka 
   ge:InstallPackage) [Install-Package], Exception
    + FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.Pac 
   kageManagement.Cmdlets.InstallPackage

@thaJeztah
Copy link
Member Author

Ah, yes, needed to skip Windows for this (can't start daemons as part of the test)

=== Failed
=== FAIL: github.com/docker/docker/integration/system TestPingBuilderHeader (0.02s)
    ping_test.go:105: assertion failed: error is not nil: protocol not available: [d9042f2f0b1bb] could not create daemon client

Starting with the 22.06 release, buildx is the default client for
docker build, which uses BuildKit as builder.

This patch changes the default builder version as advertised by
the daemon to "2" (BuildKit), so that pre-22.06 CLIs with BuildKit
support (but no buildx installed) also default to using BuildKit
when interacting with a 22.06 (or up) daemon.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@AkihiroSuda
Copy link
Member

What's current status?

@thaJeztah
Copy link
Member Author

oh! I opened this as draft for discussion; wondering if it was safe to do this, or if it needed a wider discussion

/cc @tonistiigi @crazy-max

@thaJeztah thaJeztah marked this pull request as ready for review August 18, 2022 18:14
@thaJeztah
Copy link
Member Author

discussed in the maintainers meeting, and we decided to go ahead with this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants