-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] test image-spec with embedded Platform #44124
Conversation
thaJeztah
commented
Sep 9, 2022
•
edited
Loading
edited
- follow-up to Update uses of Image platform fields in OCI image-spec #44125
- testing "embed_platform" branch from Embed Platform in Image opencontainers/image-spec#949
- testing [do not merge] test image-spec with embedded Platform buildkit#3102
Okay; BuildKit needs an update;
|
dca46ff
to
6b0daf2
Compare
|
I guess the above #44124 (comment) will be fixed if I update GHA to use a newer version of the integration tests; moby/.github/workflows/buildkit.yml Lines 73 to 75 in 924edb9
I'm wondering though; is that option set in the client, and do existing clients set that option? Would that mean that (say) docker cli 20.10 or an older version of Buildx would not be compatible with newer versions of BuildKit daemons / builders? /cc @crazy-max |
6b0daf2
to
f7b17ec
Compare
testing "embed_platform" branch from opencontainers/image-spec#949 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
f7b17ec
to
8a1fe75
Compare