daemon: getPluginExecRoot(): pass config #44310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more transparent that it's unused for Linux, and we don't pass "root", which has no relation with the path on Linux. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/plugins
kind/refactor
vvoland
approved these changes
Oct 17, 2022
corhere
approved these changes
Oct 25, 2022
| @@ -20,7 +20,7 @@ import ( | |||
| // instead of deriving path from daemon's exec-root. This is because | |||
| // plugin socket files are created here and they cannot exceed max | |||
| // path length of 108 bytes. | |||
| func getPluginExecRoot(root string) string { | |||
| func getPluginExecRoot(_ *config.Config) string { | |||
There was a problem hiding this comment.
Fun fact: if all args are unused, you can elide the names completely.
Suggested change
| func getPluginExecRoot(_ *config.Config) string { | |
| func getPluginExecRoot(*config.Config) string { |
There was a problem hiding this comment.
Oh! TIL didn't know that!
cpuguy83
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this stashed in another branch, but wasn't really related to those changes, so lets move it separate
This makes it more transparent that it's unused for Linux, and we don't pass "root", which has no relation with the path on Linux.