[23.0 backport] daemon/config: ignore UTF-8 BOM in config JSON #44777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RFC 8259] allows for JSON implementations to optionally ignore a BOM when it helps with interoperability; do so in Moby as Notepad (the only text editor available out of the box in many versions of Windows Server) insists on writing UTF-8 with a BOM. [RFC 8259]: https://tools.ietf.org/html/rfc8259#section-8.1 Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com> (cherry picked from commit bb19265) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com> (cherry picked from commit cba3edb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/enhancement
|
@neersighted @vvoland ptal (cherry-pick was clean) |
vvoland
approved these changes
Jan 10, 2023
neersighted
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Strip a BOM when present in the config JSON.
RFC 8259 allows for JSON implementations to optionally ignore a BOM when it helps with interoperability; do so in Moby as Notepad (the only text editor available out of the box in many versions of Windows server) insists on writing UTF-8 with a BOM.
- How I did it
bytes.TrimPrefix- How to verify it
Unit tests.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
