-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: fully resolve apparmor_parser
regression
#44982
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
This reverts commit ab3fa46. This fix was partial, and is not needed with the proper fix in containerd. Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
43f48d6
to
c4c5468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is slightly outdated: it still lists the prerelease pseudo-version for the containerd bump
Cherry-picked in #45043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for picking this one up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (saw the PR, but somehow looks like I didn't review it 😅)
- What I did
- How I did it
Pull in containerd/containerd#8087 from containerd, and drop the partial fix we made in this repository.
- How to verify it
We really could use some sort of binary download from our CI jobs to make the friction of manual testing easier. But for now, manually, and by reviewing the clean revert of the offending change in containerd.
- Description for the changelog
apparmor_parser
is missing.