builder/remotecontext: deprecate CachableSource, NewCachableSource #45626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type (as well as TarsumBackup), was used for the experimental --stream support for the classic builder. This feature was removed in commit 6ca3ec8, which also removed uses of the CachableSource type. As far as I could find, there's no external consumers of these types, but let's deprecated it, to give potential users a heads-up that it will be removed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/builder
status/2-code-review
impact/deprecation
process/cherry-pick
area/builder/classic-builder
crazy-max
approved these changes
May 26, 2023
neersighted
approved these changes
May 26, 2023
|
Thx! I'll bring this one in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type (as well as TarsumBackup), was used for the experimental --stream support for the classic builder. This feature was removed in commit 6ca3ec8 (#39983), which also removed uses of the CachableSource type.
As far as I could find, there's no external consumers of these types, but let's deprecated it, to give potential users a heads-up that it will be removed.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)