Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0 backport] Fix npe in exec resize when exec errored #45643

Merged
merged 1 commit into from May 29, 2023
Merged

[24.0 backport] Fix npe in exec resize when exec errored #45643

merged 1 commit into from May 29, 2023

Commits on May 28, 2023

  1. Fix npe in exec resize when exec errored 

    In cases where an exec start failed the exec process will be nil even
though the channel to signal that the exec started was closed.

Ideally ExecConfig would get a nice refactor to handle this case better
(ie. it's not started so don't close that channel).
This is a minimal fix to prevent NPE. Luckilly this would only get
called by a client and only the http request goroutine gets the panic
(http lib recovers the panic).

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 487ea81)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cpuguy83 @thaJeztah
    cpuguy83 authored and thaJeztah committed May 28, 2023
    Configuration menu
    Copy the full SHA
    d9e3991 View commit details
    Browse the repository at this point in the history