[24.0 backport] Make sure the image is unpacked for the current snapshotter #45678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching snapshotter implementations would result in an error when preparing a snapshot, check that the image is indeed unpacked for the current snapshot before trying to prepare a snapshot. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com> (cherry picked from commit ed32f5e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/images
kind/bugfix
rumpl
approved these changes
Jun 2, 2023
vvoland
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching snapshotter implementations would result in an error when preparing a snapshot, check that the image is indeed unpacked for the current snapshot before trying to prepare a snapshot.
(cherry picked from commit ed32f5e)
- What I did
Changing the snapshotter would result in docker re-pulling the image because the
PrepareSnapshotmethod would return an error. We make sure that the image we want to prepare a snapshot for is indeed unpacked for the current snapshotter before preparing it.Relates to #45273
- How I did it
- How to verify it
overlayfssnapshotterdocker run --rm hello-worldnativefor example)docker images, you should see thehello-worldimage in the listdocker run --rm hello-world, docker should just run the image without re-pulling it- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)