Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0 backport] c8d: mark stargz as requiring reference-counted mounts #45786

Merged
merged 1 commit into from Jun 21, 2023

Conversation

neersighted
Copy link
Member

- What I did

The stargz snapshotter cannot be re-mounted, so the reference-counted path must be used.

- How to verify it

docker cp with the stargz snapshotter.

@neersighted neersighted added area/storage kind/bugfix PR's that fix bugs containerd-integration Issues and PRs related to containerd integration labels Jun 21, 2023
@neersighted neersighted added this to the 24.0.3 milestone Jun 21, 2023
@neersighted neersighted marked this pull request as ready for review June 21, 2023 15:00
The stargz snapshotter cannot be re-mounted, so the reference-counted
path must be used.

Co-authored-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
(cherry picked from commit 21c0a54)
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit e6a7df0 into moby:24.0 Jun 21, 2023
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage containerd-integration Issues and PRs related to containerd integration kind/bugfix PR's that fix bugs status/4-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants