Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0 backport] Skip cache lookup for "FROM scratch" in containerd #45822

Merged
merged 1 commit into from Jun 27, 2023
Merged

[24.0 backport] Skip cache lookup for "FROM scratch" in containerd #45822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions daemon/containerd/cache.go
View file
Open in desktop
Expand Up @@ -31,6 +31,12 @@ type imageCache struct {

func (ic *imageCache) GetCache(parentID string, cfg *container.Config) (imageID string, err error) {
ctx := context.TODO()

if parentID == "" {
// TODO handle "parentless" image cache lookups ("FROM scratch")
return "", nil
}

parent, err := ic.c.GetImage(ctx, parentID, imagetype.GetImageOpts{})
if err != nil {
return "", err
Expand Down