Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0 backport] seccomp: always allow name_to_handle_at(2) #45834

Merged
merged 2 commits into from Jun 28, 2023

Conversation

neersighted
Copy link
Member

@neersighted neersighted commented Jun 27, 2023


closes #45518

Hi there, this is my first PR here, so please feel free to point me out if anything is wrong with this contribution. I looked the #45518 issue and I believe this could be a fix.

- What I did
Removed the function from the filtered syscalls as name_to_handle_at(2) is in fact innocuous and safe

- How I did it
@neersighted help at comment

- How to verify it
N/A

- Description for the changelog

Remove name_to_handle_at(2) from filtered syscalls

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Vitor Anjos <bartier@users.noreply.github.com>
(cherry picked from commit fdc9b7c)
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
@neersighted neersighted marked this pull request as draft June 28, 2023 11:35
Based on the analysis on [the previous PR][1].

  [1]: moby#45766 (review)

Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
(cherry picked from commit b335e3d)
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
@neersighted neersighted marked this pull request as ready for review June 28, 2023 11:48
@neersighted neersighted changed the title [23.0 backport] remove name_to_handle_at(2) from filtered syscalls [23.0 backport] seccomp: always allow name_to_handle_at(2) Jun 28, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 2c1c20c into moby:23.0 Jun 28, 2023
87 checks passed
@neersighted neersighted deleted the backport/45766/23.0 branch June 28, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants