Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0 backport] Improve test daemon logging, and fix TestDaemonProxy integration tests #46134

Merged
merged 4 commits into from
Aug 4, 2023
Merged

[24.0 backport] Improve test daemon logging, and fix TestDaemonProxy integration tests #46134

merged 4 commits into from
Aug 4, 2023

Commits on Aug 1, 2023

  1. Improve test daemon logging 

    1. On failed start tail the daemon logs
2. Exposes generic tailing functions to make test debugging simpler

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 914888c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cpuguy83 @thaJeztah
    cpuguy83 authored and thaJeztah committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a6f8e97 View commit details
    Browse the repository at this point in the history

  2. TestDaemonProxy: check proxy settings early 

    Allows tests to report their proxy settings for easier troubleshooting
on failures.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 8197752)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cpuguy83 @thaJeztah
    cpuguy83 authored and thaJeztah committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d6536d4 View commit details
    Browse the repository at this point in the history

  3. Fix daemon proxy test for "reload sanitized" 

    I noticed this was always being skipped because of race conditions
checking the logs.

This change adds a log scanner which will look through the logs line by
line rather than allocating a big buffer.
Additionally it adds a `poll.Check` which we can use to actually wait
for the desired log entry.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 476e788)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cpuguy83 @thaJeztah
    cpuguy83 authored and thaJeztah committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a49bca9 View commit details
    Browse the repository at this point in the history

  4. TestDaemonProxy: use new scanners to check logs 

    Also fixes up some cleanup issues.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 1a51898)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cpuguy83 @thaJeztah
    cpuguy83 authored and thaJeztah committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4cd50eb View commit details
    Browse the repository at this point in the history