[24.0 backport] distribution: update warning for deprecated image formats #46290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the same warning for both "v1 in manifest-index" and bare "v1" images. - Update URL to use a "/go/" redirect, which allows the docs team to more easily redirect the URL to relevant docs (if things move). Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 982bc0e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When we added this deprecation warning, some registries had not yet moved away from the deprecated specification, so we made the warning conditional for pulling from Docker Hub. That condition was added in 647dfe9, which is over 4 Years ago, which should be time enough for images and registries to have moved to current specifications. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8c4af5d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distribution: update warning for deprecated image formats
easily redirect the URL to relevant docs (if things move).
distribution: show image schema deprecation on all registries
When we added this deprecation warning, some registries had not yet
moved away from the deprecated specification, so we made the warning
conditional for pulling from Docker Hub.
That condition was added in 647dfe9,
which is over 4 Years ago, which should be time enough for images
and registries to have moved to current specifications.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)