Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/spec: minor fixes and touch-ups in markdown files #46370

Merged
merged 1 commit into from Aug 30, 2023

Conversation

thaJeztah
Copy link
Member

  • remove some trailing commas, which made the JSON invalid (some of these were fixed in the 1.2 spec, but not in older versions).
  • synchronise some formatting / phrasing between versions, to make them easier to compare.
  • remove non-breaking spaces (NBSP) in example outputs, and replace them with regular spaces.

- A picture of a cute animal (not mandatory but encouraged)

- remove some trailing commas, which made the JSON invalid (some of these
  were fixed in the 1.2 spec, but not in older versions).
- synchronise some formatting / phrasing between versions, to make them
  easier to compare.
- remove non-breaking spaces (`NBSP`) in example outputs, and replace
  them with regular spaces.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

After this, I'll have a look at back-filling history, per #46363 (comment)

I did a check on history:

So, in order of changes;

  • Add Onbuild to v1.0.0, v1.1.0, and v1.2.0 ("bugfix")
  • Add ArgsEscaped to v1.0.0 and make it version v1.0.1
  • Add ArgsEscaped to v1.1.0 ("bugfix")
  • Add ArgsEscaped to v1.2.0 ("bugfix")
  • Add Shell to v1.1.0 and make it v1.1.1
  • Add Shell to v1.2.0 ("bugfix")

We can REMOVE ArgsEscaped from the spec in v1.3.0, as "superseded by OCI"

@thaJeztah thaJeztah merged commit b526ce2 into moby:master Aug 30, 2023
103 checks passed
@thaJeztah thaJeztah deleted the image_spec_touch_ups branch August 30, 2023 10:46
@thaJeztah thaJeztah added this to the 25.0.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants