Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0]: Update buildkit to fix source policy order #46441

Merged
merged 1 commit into from Sep 8, 2023
Merged

[24.0]: Update buildkit to fix source policy order #46441

merged 1 commit into from Sep 8, 2023

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Sep 8, 2023

This brings in moby/buildkit#4215 which fixes a major issue with source policies in buildkit.

@cpuguy83
24.0: Update buildkit to fix source policy order
e2ab5f7 
This brings in moby/buildkit#4215 which fixes a major issue with source
policies in buildkit.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
neersighted
neersighted approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer a [24.0] prefix on the commit message and PR title for uniformity.

@cpuguy83 cpuguy83 changed the title 24.0: Update buildkit to fix source policy order [24.0]: Update buildkit to fix source policy order Sep 8, 2023
@thaJeztah thaJeztah added this to the 24.0.7 milestone Sep 8, 2023
thaJeztah
thaJeztah approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit eb2607b into moby:24.0 Sep 8, 2023
102 checks passed
@cpuguy83 cpuguy83 deleted the 24.0_update_builkit branch November 3, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neersighted neersighted neersighted approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi tonistiigi is a code owner

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees
No one assigned
Labels
area/builder/buildkit Issues affecting buildkit area/builder kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
24.0.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpuguy83 @neersighted @thaJeztah