c8d/pull: Support legacy schema1 prettyjws manifests #46513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
kind/enhancement
vvoland
force-pushed
the
c8d-pull-pretty-jws
branch
from
300fd48
to
01f599e
Compare
Makes it possible to pull `application/vnd.docker.distribution.manifest.v1+prettyjws` legacy manifests. They are not stored in their original form but are converted to the OCI manifests. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
c8d-pull-pretty-jws
branch
from
01f599e
to
68b67b3
Compare
thaJeztah
reviewed
Sep 19, 2023
| @@ -104,6 +104,10 @@ func (i *ImageService) PullImage(ctx context.Context, image, tagOrDigest string, | |||
| infoHandler := snapshotters.AppendInfoHandlerWrapper(ref.String()) | |||
| opts = append(opts, containerd.WithImageHandlerWrapper(infoHandler)) | |||
|
|
|||
| // Allow pulling application/vnd.docker.distribution.manifest.v1+prettyjws images | |||
| // by converting them to OCI manifests. | |||
| opts = append(opts, containerd.WithSchema1Conversion) | |||
There was a problem hiding this comment.
do you know if we can detect these in this flow, and print a deprecation warning? (see #46137)
There was a problem hiding this comment.
We could print that deprecation in one of the image handlers maybe? That's if the manifest is not already converted once it gets to the handler
There was a problem hiding this comment.
Yes, we can! I somehow missed the deprecation warning when looking at the non-c8d output 😄
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to pull
application/vnd.docker.distribution.manifest.v1+prettyjwslegacy manifests.They are not stored in their original form but are converted to the OCI manifests.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)