Skip TestPullAllTagsFromCentralRegistry #46633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image that this test pulls contains an error in the linux/amd64 manifest description, the reported size is 424 but the actual size is 524, making this test fail with containerd. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
added
status/2-code-review
containerd-integration
vvoland
approved these changes
Oct 12, 2023
Yeah, we should use the moby org on Docker Hub for test images, and we could push something there; maybe we need some job on the / a repository for building and pushing such images (also thinking of the Windows busybox image etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Skipped the
TestPullAllTagsFromCentralRegistrytest when using containerd.The image that this test pulls contains an error in the linux/amd64 manifest description, the reported size is 424 but the actual size is 524, making this test fail with containerd.
I've opened a ticket to fix the image used in this test #46632
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)