[24.0 backport] daemon: release sandbox even when NetworkDisabled #46702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When the default bridge is disabled by setting dockerd's
--bridge=none
option, the daemon still creates a sandbox for containers with no network attachment specified. In that caseNetworkDisabled
will be set to true.However, currently the
releaseNetwork
call will early return if NetworkDisabled is true. Thus, these sandboxes won't be deleted until the daemon is restarted. If a high number of such containers are created, the daemon would then take few minutes to start.As a side note,
NetworkDisabled
semantics is weird/broken and should be revised:NetworkDisbled
is set. Thus it allows these containers to be manually connected to other networks;- Description for the changelog
--bridge=none
option is specified.- A picture of a cute animal (not mandatory but encouraged)