vendor: github.com/containerd/containerd v1.7.19, migrate to github.com/containerd/platforms module

[thaJeztah]

• depends on / stacked on pkg/platforms: internalize in daemon/containerd #47141
• depends on / stacked on vendor: assorted golang.org/x/... updates #47143
• depends on / stacked on integration: improve some asserts, and add asserts for unhandled errs #47147
• relates to / depends on Use github.com/containerd/platforms package containerd/containerd#9662
• depends on above being backported [release/1.7] Migrate platforms package to github.com/containerd/platforms containerd/containerd#10292
• depends on don't depend on containerd platform.Parse to return a typed error #47863
• depends on (ideally) module requirements to be lowered: downgrade minimum required version of hcsshim to v0.10.0 containerd/platforms#5
• depends on vendor: github.com/containerd/containerd v1.7.18 #47909
• depends on [release/1.7] Prepare release notes for api v1.7.19 containerd/containerd#10386
• depends on / stacked on remove uses of platforms.Platform alias #47946
• depends on / stacked on vendor: github.com/microsoft/hcsshim v0.11.7 #48091
• depends on [release/1.7] Prepare release notes for v1.7.19 containerd/containerd#10391 🎉

Migrate to github.com/containerd/platforms module

Containerd's "platforms" package is being moved to a separate module. This
allows updating the platforms parsing independent of the containerd module
itself.

For existing containerd versions (1.6, 1.7), the package in containerd will
be an alias for the new module.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

Ah, looks like some updates are needed;

# github.com/docker/docker/libcontainerd/local
libcontainerd/local/local_windows.go:944:34: cannot use p[i].CreateTimestamp (variable of type time.Time) as *timestamppb.Timestamp value in struct literal

[thaJeztah]

• opened downgrade minimum required version of hcsshim to v0.10.0 containerd/platforms#5 to prevent having to upgrade hcsshim

[thaJeztah]

Two tests failing that look related, looks like there's some change in behavior in the package;

=== FAIL: github.com/docker/docker/integration/build TestBuildPlatformInvalid (0.06s)
    build_test.go:685: assertion failed: expression is false: errdefs.IsInvalidParameter(err)

moby/integration/build/build_test.go

Lines 680 to 685 in 27e85c7

	Platform: "foobar",
	})
	assert.Assert(t, err != nil)
	assert.ErrorContains(t, err, "unknown operating system or architecture")
	assert.Assert(t, errdefs.IsInvalidParameter(err))

=== FAIL: amd64.integration.image TestImagePullPlatformInvalid (0.01s)
    pull_test.go:37: assertion failed: expression is false: errdefs.IsInvalidParameter(err)

moby/integration/image/pull_test.go

Lines 34 to 37 in 27e85c7

	_, err := client.ImagePull(ctx, "docker.io/library/hello-world:latest", types.ImagePullOptions{Platform: "foobar"})
	assert.Assert(t, err != nil)
	assert.ErrorContains(t, err, "unknown operating system or architecture")
	assert.Assert(t, errdefs.IsInvalidParameter(err))

[thaJeztah]

Improved the test-assert a bit, and it looks like it's returning a 500 / internal server error;

=== RUN   TestImagePullPlatformInvalid
    pull_test.go:37: assertion failed: invalid type for expected: func(error) error: errdefs.errSystem: Error response from daemon: "foobar": unknown operating system or architecture: invalid argument
--- FAIL: TestImagePullPlatformInvalid (0.01s)

[thaJeztah]

Daemon logs show that it returns an untyped error, hence using the default (500 / Internal Server error);

time="2024-01-21T00:18:31.260074294Z" level=debug msg="Calling POST /v1.45/images/create?fromImage=hello-world&platform=foobar&tag=latest"
time="2024-01-21T00:18:31.260220544Z" level=debug msg="FIXME: Got an API for which error does not match any expected type!!!" error="\"foobar\": unknown operating system or architecture: invalid argument" error_type="*fmt.wrapError" module=api
time="2024-01-21T00:18:31.260320336Z" level=error msg="Handler for POST /v1.45/images/create returned error: \"foobar\": unknown operating system or architecture: invalid argument"
time="2024-01-21T00:18:31.260407169Z" level=debug msg="FIXME: Got an API for which error does not match any expected type!!!" error="\"foobar\": unknown operating system or architecture: invalid argument" error_type="*fmt.wrapError" module=api

[thaJeztah]

Found the likely cause; the new module doesn't use containerd errdefs;

[thaJeztah]

Some error messages need to be updated in tests;

=== Failed
=== FAIL: amd64.integration.image TestImportWithCustomPlatformReject/_______ (0.00s)
    import_test.go:182: assertion failed: expected error to contain "is an invalid component", got "Error response from daemon: \"       \" is an invalid OS component of \"       \": OSAndVersion specifier component must match \"^([A-Za-z0-9_-]+)(?:\\\\(([A-Za-z0-9_.-]*)\\\\))?$\": invalid argument"
        Error response from daemon: "       " is an invalid OS component of "       ": OSAndVersion specifier component must match "^([A-Za-z0-9_-]+)(?:\\(([A-Za-z0-9_.-]*)\\))?$": invalid argument
    --- FAIL: TestImportWithCustomPlatformReject/_______ (0.00s)

=== FAIL: amd64.integration.image TestImportWithCustomPlatformReject// (0.00s)
    import_test.go:182: assertion failed: expected error to contain "is an invalid component", got "Error response from daemon: \"\" is an invalid OS component of \"/\": OSAndVersion specifier component must match \"^([A-Za-z0-9_-]+)(?:\\\\(([A-Za-z0-9_.-]*)\\\\))?$\": invalid argument"
        Error response from daemon: "" is an invalid OS component of "/": OSAndVersion specifier component must match "^([A-Za-z0-9_-]+)(?:\\(([A-Za-z0-9_.-]*)\\))?$": invalid argument
    --- FAIL: TestImportWithCustomPlatformReject// (0.00s)

=== FAIL: amd64.integration.image TestImportWithCustomPlatformReject (0.01s)

[thaJeztah]

Yay! CodeCov action is having a bad day on Windows;